[Mellanox] Fix wrong type of parameter in mlnx-sfpd notification#2950
Merged
lguohan merged 1 commit intosonic-net:masterfrom May 28, 2019
keboliu:sfpd-fix
Merged
[Mellanox] Fix wrong type of parameter in mlnx-sfpd notification#2950lguohan merged 1 commit intosonic-net:masterfrom keboliu:sfpd-fix
lguohan merged 1 commit intosonic-net:masterfrom
keboliu:sfpd-fix
Conversation
lguohan
approved these changes
May 28, 2019
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
yxieca
pushed a commit
that referenced
this pull request
May 29, 2019
yxieca
pushed a commit
that referenced
this pull request
Aug 28, 2023
…atically (#16265) src/sonic-utilities * 1ed5b5a9 - (HEAD -> 202205, origin/202205) Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (cherry-pick to 202205) (#2950) (4 days ago) [longhuan-cisco] * ba327726 - Fix in config override when all asic namespaces not present in golden_config_db (#2946) (4 days ago) [judyjoseph]
yxieca
pushed a commit
that referenced
this pull request
Nov 7, 2023
…lly (#17094) src/sonic-swss * 01bf3b19 - (HEAD -> 202205, origin/202205) [muxorch] Fixing updateRoute logic (#2950) (5 hours ago) [Nikola Dancejic] * 1e264e01 - Handle Mac address 'none' (#2593) (9 hours ago) [Prince Sunny] * dc0e29b4 - [202205][teamd]: Clean teamd process if LAG creation fails (#2888) (#2932) (4 days ago) [Lawrence Lee]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
fix an mlnx-sfpd bug that sends out notifications with the wrong type of parameters:
- How I did it
change the type of the parameter to string.
- How to verify it
trigger cable plug in/plug out event on Mellanox platform and see the result of xcvrd.
with this fix, events sends to xcvrd with expected parameter type and can be handled correctly.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)